Changes to TRT-LLM download tool for multigpu distributed case #3830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/utils.py 2025-09-22 06:35:28.523784+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/utils.py 2025-09-22 06:36:00.657186+00:00
@@ -863,6 +863,6 @@
return False
def is_thor() -> bool:
if torch.cuda.get_device_capability() in [(11, 0)]:
- return True
\ No newline at end of file
+ return True
apbose
force-pushed
the
abose/trt_llm_installation_dist
branch
from
6e99bbc to
7134053
Compare
apbose
force-pushed
the
abose/trt_llm_installation_dist
branch
from
3f1fa7e to
54948d9
Compare
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/distributed/utils.py 2025-09-25 19:33:28.176615+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/distributed/utils.py 2025-09-25 19:34:02.325958+00:00
@@ -100,11 +100,10 @@
return True
except Exception as e:
logger.warning(f"Failed to detect CUDA version: {e}")
return False
-
return True
def _cache_root() -> Path:
apbose
force-pushed
the
abose/trt_llm_installation_dist
branch
3 times, most recently
from
2bbc423 to
5beefc0
Compare
apbose
changed the title
apbose
force-pushed
the
abose/trt_llm_installation_dist
branch
from
5beefc0 to
809c7ee
Compare
apbose
changed the title
apbose
force-pushed
the
abose/trt_llm_installtion
branch
5 times, most recently
from
b96b9ee to
2f2cd31
Compare
apbose
force-pushed
the
abose/trt_llm_installation_dist
branch
from
809c7ee to
5fb74da
Compare
github-actions
bot
added
documentation
github-actions
bot
removed
documentation
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/distributed/test_nccl_ops.py 2025-10-13 18:42:31.890493+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/distributed/test_nccl_ops.py 2025-10-13 18:43:14.026641+00:00
@@ -23,10 +23,11 @@
if not dist.is_initialized():
dist.init_process_group(
backend="nccl",
init_method="env://",
)
+
class DistributedGatherModel(nn.Module):
def __init__(self, input_dim, world_size, group_name):
super().__init__()
self.fc = nn.Linear(input_dim, input_dim)
apbose
force-pushed
the
abose/trt_llm_installation_dist
branch
2 times, most recently
from
d289587 to
bd02455
Compare
apbose
force-pushed
the
abose/trt_llm_installation_dist
branch
from
bd02455 to
38224c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRT-LLM installation tool for distributed
dynamo/distributed/utils.pywith the initialization and cleanup of the env to be done on user side. (We do it intests/py/dynamo/distributedandexamples/distributed_inference/tensor_parallel_initialize_dist)